Port over some baselined hover/quick info tests #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ports over fourslash tests for hover/quick info functionality from the original TypeScript test suite. The tests validate hover information displayed when users hover over various language constructs including classes, enums, functions, interfaces, modules, and variables.
Key Changes
- Ported baseline test files that establish expected hover output for different TypeScript language features
- Tests cover a comprehensive range of hover scenarios: class members, function overloads, enum members, module aliases, and variable declarations
- Added JSON output format that captures both the hover content and position information for each test marker
|
Also, I think these baselines are going in different directories than before - I hope that's fine? |
gabritto
reviewed
Jul 30, 2025
| result = strings.Split(*item.Contents.String, "\n") | ||
| } | ||
| if item.Contents.MarkedStringWithLanguage != nil { | ||
| result = appendLinesForMarkedStringWithLanguage(result, item.Contents.MarkedStringWithLanguage) |
There was a problem hiding this comment.
We probably don't need this, I think this has been deprecated, but I guess it's fine to have it.
gabritto
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ports over fourslash tests for quick info.
Things are definitely not apples-to-apples given that hovers don't use display parts like quick info did. I did not do a very thorough diff, but some notable differences I picked up on:
@see/@linkdoesn't process text the same.@inheritdocdoesn't workthis,class, anddefault(like anexport default) are both not workingThere are only a few new failing tests, that I believe fail with something like the following: